| Ticket UUID: | 475846 | |||
| Title: | install leaves control broken | |||
| Type: | Bug | Version: | None | |
| Submitter: | dgp | Created on: | 2001-10-28 23:27:09 | |
| Subsystem: | control | Assigned To: | dgp | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2001-11-08 13:33:14 | |
| Resolution: | Fixed | Closed By: | andreas_kupries | |
| Closed on: | 2001-11-08 06:33:14 | |||
| Description: |
The control package makes use of Tcl's auto-loader
to load only the commands that are actually used.
In order for this to work, a "tclIndex" file must
be generated and installed, but tcllib's 'make install'
does not do this.
Note also that 'make install' blindly installs all
*.tcl files, assuming they are all part of the package.
If other Tcl scripts (developer aids, etc.) are
included in the source directory, they need to have
a name not matching *.tcl so they are not mistakenly
installed.
Proposed fix to control:
rename index.tcl -> genIndex
generate tclIndex and check it in to CVS
now developer responsbility to keep it
up to date.
Proposed fix to tcllib Makefile:
have 'make install' install files named
'tclIndex' as well as '*.tcl'
As currently shipped with tcllib 1.1, control 0.0
does not work at all.
| |||
| User Comments: |
andreas_kupries added on 2001-11-08 13:33:14:
Logged In: YES user_id=75003 Patch committed to head. andreas_kupries added on 2001-11-07 09:55:49: File Added - 12947: control.diff.4 Logged In: YES user_id=75003 New patch, checking existence of tclIndex before copying. dgp added on 2001-11-06 10:02:18: Logged In: YES user_id=80530 OK, the latest patch works. All of the error messages: cp: base64/tclIndex: No such file or directory .... cp: sha1/tclIndex: No such file or directory when running install.sh are less than ideal. andreas_kupries added on 2001-11-06 08:52:47: File Added - 12906: control.diff.3 andreas_kupries added on 2001-11-06 08:52:40: Logged In: YES user_id=75003 Enclosed new patch fixing the problem with mkInstallScripts.tcl dgp added on 2001-11-06 07:08:31: Logged In: YES user_id=80530 The patch still needs changes to mkInstallScripts.tcl so that the Unix installer script installs tclIndex files. andreas_kupries added on 2001-11-04 12:10:23: File Added - 12841: control.diff.2 Logged In: YES user_id=75003 New patch. Fixes an additional heretofore unknown error in the "make dist" target I found when exercising my changes. Please review. andreas_kupries added on 2001-11-04 11:58:01: File Added - 12840: control.diff Logged In: YES user_id=75003 Enclosed a patch for the master Makefile(.in). dgp added on 2001-11-03 11:18:43: Logged In: YES user_id=80530 Note: Be sure that 'make dist' as well as 'make install' copies over any tclIndex files. dgp added on 2001-11-03 11:16:06: Logged In: YES user_id=80530 Changes to control modules described have been committed. Still need fixes to the master Makefile.in. andreas_kupries added on 2001-11-01 00:20:49: Logged In: YES user_id=75003 I agree with the changes above. | |||
Attachments:
- control.diff.4 [download] added by andreas_kupries on 2001-11-07 09:55:49. [details]
- control.diff.3 [download] added by andreas_kupries on 2001-11-06 08:52:40. [details]
- control.diff.2 [download] added by andreas_kupries on 2001-11-04 12:10:23. [details]
- control.diff [download] added by andreas_kupries on 2001-11-04 11:58:01. [details]